package org.github.tess1o.geopulse.geocoding.service; import org.github.tess1o.geopulse.testsupport.TestIds; import org.github.tess1o.geopulse.testsupport.TestCoordinates; import io.quarkus.test.common.QuarkusTestResource; import io.quarkus.test.junit.QuarkusTest; import jakarta.inject.Inject; import jakarta.persistence.EntityManager; import jakarta.transaction.Transactional; import jakarta.ws.rs.ForbiddenException; import jakarta.ws.rs.NotFoundException; import org.github.tess1o.geopulse.db.PostgisTestResource; import org.github.tess1o.geopulse.geocoding.dto.ReverseGeocodingDTO; import org.github.tess1o.geopulse.geocoding.dto.ReverseGeocodingUpdateDTO; import org.github.tess1o.geopulse.geocoding.model.ReverseGeocodingLocationEntity; import org.github.tess1o.geopulse.geocoding.repository.ReverseGeocodingLocationRepository; import org.github.tess1o.geopulse.testsupport.SerializedDatabaseTest; import org.github.tess1o.geopulse.user.model.UserEntity; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; import org.locationtech.jts.geom.Point; import java.time.Instant; import java.util.List; import java.util.UUID; import static org.junit.jupiter.api.Assertions.*; /** * Comprehensive integration tests for ReverseGeocodingManagementService. * Tests the sophisticated copy-on-write logic, authorization, and timeline synchronization. *

* NO MOCKS - Uses real database with all services integrated. */ @QuarkusTest @QuarkusTestResource(value = PostgisTestResource.class) @SerializedDatabaseTest class ReverseGeocodingManagementServiceTest { @Inject ReverseGeocodingManagementService managementService; @Inject ReverseGeocodingLocationRepository repository; @Inject EntityManager entityManager; private static UUID USER_A_ID; private static UUID USER_B_ID; private static final double TEST_LAT = 41.7589; private static final double TEST_LON = -72.9851; private TestCoordinates.Scope coordinateScope; @BeforeEach @Transactional void setupUsers() { coordinateScope = TestCoordinates.newScope(); UserEntity userA = UserEntity.builder() .email(TestIds.uniqueEmail("it-user")) .fullName("User A") .timezone("UTC") .isActive(true) .build(); entityManager.persist(userA); UserEntity userB = UserEntity.builder() .email(TestIds.uniqueEmail("it-user")) .fullName("User B") .timezone("UTC") .isActive(true) .build(); entityManager.persist(userB); entityManager.flush(); USER_A_ID = userA.getId(); USER_B_ID = userB.getId(); } @AfterEach @Transactional void cleanup() { } // ==================== Copy-on-Write: User Modifying Original ==================== @Test @Transactional @DisplayName("COW Test 1: Modifying original creates user copy") void testModifyingOriginalCreatesUserCopy() { // Given: Original entity Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Starbucks"); repository.persist(original); entityManager.flush(); Long originalId = original.getId(); // When: User A modifies it ReverseGeocodingUpdateDTO updateDTO = new ReverseGeocodingUpdateDTO(); updateDTO.setDisplayName("My Coffee Shop"); updateDTO.setCity("New York"); updateDTO.setCountry("USA"); ReverseGeocodingDTO result = managementService.updateGeocodingResult(USER_A_ID, originalId, updateDTO); // Then: New user-specific copy created assertNotNull(result); assertNotEquals(originalId, result.getId(), "Should create new entity"); assertEquals("My Coffee Shop", result.getDisplayName()); assertTrue(result.isUserSpecific(), "Should be user-specific"); // And: Original still exists unchanged ReverseGeocodingLocationEntity originalCheck = repository.findById(originalId); assertNotNull(originalCheck, "Original should still exist"); assertEquals("Starbucks", originalCheck.getDisplayName(), "Original unchanged"); assertTrue(originalCheck.isOriginal(), "Should still be original"); } @Test @Transactional @DisplayName("COW Test 2: Timeline stays remapped to user copy") void testTimelineStaysRemappedToUserCopy() { // Given: Original with timeline stay Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Starbucks"); repository.persist(original); entityManager.flush(); createTimelineStay(USER_A_ID, original.getId(), coords, "Starbucks"); // When: User A modifies original ReverseGeocodingUpdateDTO updateDTO = new ReverseGeocodingUpdateDTO(); updateDTO.setDisplayName("My Coffee Shop"); updateDTO.setCity("New York"); updateDTO.setCountry("USA"); ReverseGeocodingDTO result = managementService.updateGeocodingResult(USER_A_ID, original.getId(), updateDTO); // Then: Timeline stay now references new copy List stays = getTimelineStaysForUser(USER_A_ID); assertEquals(1, stays.size(), "Should have 1 timeline stay"); Long geocodingId = ((Number) stays.get(0)[0]).longValue(); String locationName = (String) stays.get(0)[1]; assertEquals(result.getId(), geocodingId, "Should reference new copy"); assertEquals("My Coffee Shop", locationName, "Should have updated name"); } @Test @Transactional @DisplayName("COW Test 3: User B's timeline stays unchanged after User A modifies") void testUserBTimelineStaysUnchangedWhenUserAModifies() { // Given: Original with timeline stays for both users Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Starbucks"); repository.persist(original); entityManager.flush(); createTimelineStay(USER_A_ID, original.getId(), coords, "Starbucks"); createTimelineStay(USER_B_ID, original.getId(), coords, "Starbucks"); // When: User A modifies ReverseGeocodingUpdateDTO updateDTO = new ReverseGeocodingUpdateDTO(); updateDTO.setDisplayName("My Coffee Shop"); updateDTO.setCity("New York"); updateDTO.setCountry("USA"); managementService.updateGeocodingResult(USER_A_ID, original.getId(), updateDTO); // Then: User B's timeline stay still references original List userBStays = getTimelineStaysForUser(USER_B_ID); assertEquals(1, userBStays.size(), "User B should have 1 stay"); Long userBGeocodingId = ((Number) userBStays.get(0)[0]).longValue(); String userBLocationName = (String) userBStays.get(0)[1]; assertEquals(original.getId(), userBGeocodingId, "User B should still reference original"); assertEquals("Starbucks", userBLocationName, "User B's name unchanged"); } // ==================== Copy-on-Write: User Modifying Own Copy ==================== @Test @Transactional @DisplayName("COW Test 4: Modifying own copy updates in-place") void testModifyingOwnCopyUpdatesInPlace() { // Given: User A's custom copy Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity userCopy = createUserCopy(USER_A_ID, coords, "My Coffee Shop"); repository.persist(userCopy); entityManager.flush(); Long copyId = userCopy.getId(); // When: User A modifies their own copy ReverseGeocodingUpdateDTO updateDTO = new ReverseGeocodingUpdateDTO(); updateDTO.setDisplayName("My Updated Coffee Shop"); updateDTO.setCity("Brooklyn"); updateDTO.setCountry("USA"); ReverseGeocodingDTO result = managementService.updateGeocodingResult(USER_A_ID, copyId, updateDTO); // Then: Same entity updated in-place assertEquals(copyId, result.getId(), "Should be same entity ID"); assertEquals("My Updated Coffee Shop", result.getDisplayName()); assertEquals("Brooklyn", result.getCity()); // And: No new entity created long countAfter = repository.count("user.id = ?1", USER_A_ID); assertEquals(1, countAfter, "Should still have only 1 entity"); } // ==================== Authorization Tests ==================== @Test @Transactional @DisplayName("Auth Test 1: User cannot modify another user's copy") void testUserCannotModifyAnotherUsersCopy() { // Given: User A's custom copy Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity userACopy = createUserCopy(USER_A_ID, coords, "My Coffee Shop"); repository.persist(userACopy); entityManager.flush(); // When: User B tries to modify it ReverseGeocodingUpdateDTO updateDTO = new ReverseGeocodingUpdateDTO(); updateDTO.setDisplayName("Hacked"); updateDTO.setCity("New York"); updateDTO.setCountry("USA"); // Then: 403 Forbidden assertThrows(ForbiddenException.class, () -> { managementService.updateGeocodingResult(USER_B_ID, userACopy.getId(), updateDTO); }, "Should throw ForbiddenException"); // And: Entity unchanged ReverseGeocodingLocationEntity checkEntity = repository.findById(userACopy.getId()); assertEquals("My Coffee Shop", checkEntity.getDisplayName(), "Should be unchanged"); } @Test @Transactional @DisplayName("Auth Test 2: User cannot access another user's copy") void testUserCannotAccessAnotherUsersCopy() { // Given: User A's custom copy Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity userACopy = createUserCopy(USER_A_ID, coords, "My Coffee Shop"); repository.persist(userACopy); entityManager.flush(); // When: User B tries to access it // Then: 403 Forbidden assertThrows(ForbiddenException.class, () -> { managementService.getGeocodingResult(USER_B_ID, userACopy.getId()); }, "Should throw ForbiddenException"); } @Test @Transactional @DisplayName("Auth Test 3: User can access originals") void testUserCanAccessOriginals() { // Given: Original entity Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Starbucks"); repository.persist(original); entityManager.flush(); // When: User A accesses it ReverseGeocodingDTO result = managementService.getGeocodingResult(USER_A_ID, original.getId()); // Then: Success assertNotNull(result); assertEquals("Starbucks", result.getDisplayName()); assertFalse(result.isUserSpecific(), "Should not be user-specific"); } @Test @Transactional @DisplayName("Auth Test 4: Non-existent entity throws NotFoundException") void testNonExistentEntityThrowsNotFound() { // When: Access non-existent entity // Then: 404 Not Found assertThrows(NotFoundException.class, () -> { managementService.getGeocodingResult(USER_A_ID, 999999L); }, "Should throw NotFoundException"); } // ==================== Management Page Tests ==================== @Test @Transactional @DisplayName("Management Test 1: User sees only relevant entities") void testManagementPageShowsRelevantEntitiesOnly() { // Given: Multiple entities Point loc1 = coord(-73.9851, 40.7589); Point loc2 = coord(-73.9654, 40.7829); Point loc3 = coord(-74.0060, 40.7128); // Original referenced by User A ReverseGeocodingLocationEntity original1 = createOriginal(loc1, "Location 1"); repository.persist(original1); // User A's copy ReverseGeocodingLocationEntity userACopy = createUserCopy(USER_A_ID, loc2, "My Location 2"); repository.persist(userACopy); // Unreferenced original (should not appear) ReverseGeocodingLocationEntity original3 = createOriginal(loc3, "Location 3 Unreferenced"); repository.persist(original3); // User B's copy (should not appear for User A) ReverseGeocodingLocationEntity userBCopy = createUserCopy(USER_B_ID, loc3, "User B Location"); repository.persist(userBCopy); entityManager.flush(); createTimelineStay(USER_A_ID, original1.getId(), loc1, "Location 1"); // When: User A fetches management page List results = managementService.getGeocodingResults( USER_A_ID, null, null, 1, 50, "lastAccessedAt", "desc"); // Then: Only 2 entities (referenced original + own copy) assertEquals(2, results.size(), "Should show 2 entities"); List resultIds = results.stream().map(ReverseGeocodingDTO::getId).toList(); assertTrue(resultIds.contains(original1.getId()), "Should include referenced original"); assertTrue(resultIds.contains(userACopy.getId()), "Should include own copy"); assertFalse(resultIds.contains(original3.getId()), "Should NOT include unreferenced original"); assertFalse(resultIds.contains(userBCopy.getId()), "Should NOT include user B's copy"); } @Test @Transactional @DisplayName("Management Test 2: Count matches results") void testCountMatchesResults() { // Given: 3 entities for user A for (int i = 0; i < 3; i++) { Point coords = coord(-73.9 - i * 0.01, 40.7 + i * 0.01); ReverseGeocodingLocationEntity entity = createUserCopy(USER_A_ID, coords, "Location " + i); repository.persist(entity); } entityManager.flush(); // When: Get count and results long count = managementService.countGeocodingResults(USER_A_ID, null, null); List results = managementService.getGeocodingResults( USER_A_ID, null, null, 1, 50, "lastAccessedAt", "desc"); // Then: Count matches assertEquals(3, count); assertEquals(3, results.size()); assertEquals(count, results.size()); } // ==================== Concurrent Modification Tests ==================== @Test @Transactional @DisplayName("Concurrency Test: Two users modifying same original creates separate copies") void testTwoUsersModifyingSameOriginalCreatesSeparateCopies() { // Given: Original Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Starbucks"); repository.persist(original); entityManager.flush(); Long originalId = original.getId(); // When: User A modifies ReverseGeocodingUpdateDTO updateA = new ReverseGeocodingUpdateDTO(); updateA.setDisplayName("My Coffee Shop"); updateA.setCity("New York"); updateA.setCountry("USA"); ReverseGeocodingDTO resultA = managementService.updateGeocodingResult(USER_A_ID, originalId, updateA); // And: User B modifies ReverseGeocodingUpdateDTO updateB = new ReverseGeocodingUpdateDTO(); updateB.setDisplayName("Mon Café"); updateB.setCity("New York"); updateB.setCountry("USA"); ReverseGeocodingDTO resultB = managementService.updateGeocodingResult(USER_B_ID, originalId, updateB); // Then: Three entities exist (original + 2 copies) assertEquals(1, repository.count("user.id = ?1", USER_A_ID), "Should have 1 copy for user A"); assertEquals(1, repository.count("user.id = ?1", USER_B_ID), "Should have 1 copy for user B"); // And: Each user has their own copy assertNotEquals(resultA.getId(), resultB.getId(), "Should be different copies"); assertEquals("My Coffee Shop", resultA.getDisplayName()); assertEquals("Mon Café", resultB.getDisplayName()); // And: Original unchanged ReverseGeocodingLocationEntity originalCheck = repository.findById(originalId); assertEquals("Starbucks", originalCheck.getDisplayName(), "Original unchanged"); } // ==================== Helper Methods ==================== private ReverseGeocodingLocationEntity createOriginal(Point coords, String displayName) { ReverseGeocodingLocationEntity entity = new ReverseGeocodingLocationEntity(); entity.setUser(null); entity.setRequestCoordinates(coords); entity.setResultCoordinates(coords); entity.setDisplayName(displayName); entity.setProviderName("nominatim"); entity.setCity("New York"); entity.setCountry("USA"); entity.setCreatedAt(Instant.now()); entity.setLastAccessedAt(Instant.now()); return entity; } private ReverseGeocodingLocationEntity createUserCopy(UUID userId, Point coords, String displayName) { ReverseGeocodingLocationEntity entity = new ReverseGeocodingLocationEntity(); entity.setUser(entityManager.getReference(UserEntity.class, userId)); entity.setRequestCoordinates(coords); entity.setResultCoordinates(coords); entity.setDisplayName(displayName); entity.setProviderName("nominatim"); entity.setCity("New York"); entity.setCountry("USA"); entity.setCreatedAt(Instant.now()); entity.setLastAccessedAt(Instant.now()); return entity; } private void createTimelineStay(UUID userId, Long geocodingId, Point coords, String locationName) { String sql = """ INSERT INTO timeline_stays (user_id, timestamp, stay_duration, location, location_name, geocoding_id, created_at, last_updated, location_source) VALUES (?, ?, ?, ?, ?, ?, ?, ?, 'GEOCODING') """; entityManager.createNativeQuery(sql) .setParameter(1, userId) .setParameter(2, Instant.now()) .setParameter(3, 300L) .setParameter(4, coords) .setParameter(5, locationName) .setParameter(6, geocodingId) .setParameter(7, Instant.now()) .setParameter(8, Instant.now()) .executeUpdate(); } @SuppressWarnings("unchecked") private List getTimelineStaysForUser(UUID userId) { String sql = "SELECT geocoding_id, location_name FROM timeline_stays WHERE user_id = ? ORDER BY id"; return entityManager.createNativeQuery(sql) .setParameter(1, userId) .getResultList(); } // ==================== Reconciliation Tests ==================== @Test @Transactional @DisplayName("Reconciliation Test 1: User cannot reconcile another user's copy") void testCannotReconcileAnotherUsersCopy() { // Given: User A's custom copy Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity userACopy = createUserCopy(USER_A_ID, coords, "User A Location"); repository.persist(userACopy); entityManager.flush(); // When: User B tries to reconcile it // Then: 403 Forbidden assertThrows(ForbiddenException.class, () -> { managementService.reconcileWithProvider(USER_B_ID, userACopy.getId(), "nominatim"); }, "Should throw ForbiddenException when reconciling another user's copy"); } @Test @Transactional @DisplayName("Reconciliation Test 2: User can reconcile original entity") void testUserCanReconcileOriginal() { // Given: Original entity Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Original Location"); repository.persist(original); entityManager.flush(); Long originalId = original.getId(); // When: User A reconciles it (this will call the actual provider) // Then: No exception thrown (original entities can be reconciled by any user) assertDoesNotThrow(() -> { ReverseGeocodingDTO result = managementService.reconcileWithProvider(USER_A_ID, originalId, "nominatim"); assertNotNull(result); }); } @Test @Transactional @DisplayName("Reconciliation Test 3: User can reconcile their own copy") void testUserCanReconcileOwnCopy() { // Given: User A's copy Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity userCopy = createUserCopy(USER_A_ID, coords, "My Location"); repository.persist(userCopy); entityManager.flush(); Long copyId = userCopy.getId(); // When: User A reconciles their own copy // Then: No exception thrown assertDoesNotThrow(() -> { ReverseGeocodingDTO result = managementService.reconcileWithProvider(USER_A_ID, copyId, "nominatim"); assertNotNull(result); }); } @Test @Transactional @DisplayName("Reconciliation Test 4: Reconciliation with non-existent entity throws NotFoundException") void testReconcileNonExistentEntity() { // When: Try to reconcile non-existent entity // Then: 404 Not Found assertThrows(NotFoundException.class, () -> { managementService.reconcileWithProvider(USER_A_ID, 999999L, "nominatim"); }, "Should throw NotFoundException for non-existent entity"); } @Test @Transactional @DisplayName("Reconciliation Test 5: Multiple users can reconcile same original independently") void testMultipleUsersReconcileSameOriginal() { // Given: Original entity Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Shared Location"); repository.persist(original); entityManager.flush(); Long originalId = original.getId(); // When: Both users reconcile the same original // Then: Both should succeed without interfering with each other assertDoesNotThrow(() -> { ReverseGeocodingDTO resultA = managementService.reconcileWithProvider(USER_A_ID, originalId, "nominatim"); assertNotNull(resultA); }); assertDoesNotThrow(() -> { ReverseGeocodingDTO resultB = managementService.reconcileWithProvider(USER_B_ID, originalId, "nominatim"); assertNotNull(resultB); }); // Original should still exist ReverseGeocodingLocationEntity originalCheck = repository.findById(originalId); assertNotNull(originalCheck); } @Test @Transactional @DisplayName("Reconciliation Test 6: Verify reconciliation uses correct provider") void testReconciliationUsesCorrectProvider() { // Given: Original entity from one provider Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Location"); original.setProviderName("nominatim"); repository.persist(original); entityManager.flush(); // When: Reconcile with different provider // Then: Should succeed (provider switch is allowed) assertDoesNotThrow(() -> { ReverseGeocodingDTO result = managementService.reconcileWithProvider(USER_A_ID, original.getId(), "nominatim"); assertNotNull(result); }); } @Test @Transactional @DisplayName("Reconciliation Test 7: Verify security on reconciliation") void testReconciliationSecurityChecks() { // Given: Three entities Point coords1 = coord(TEST_LON, TEST_LAT); Point coords2 = coord(TEST_LON + 0.01, TEST_LAT); Point coords3 = coord(TEST_LON + 0.02, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords1, "Original"); ReverseGeocodingLocationEntity userACopy = createUserCopy(USER_A_ID, coords2, "User A Copy"); ReverseGeocodingLocationEntity userBCopy = createUserCopy(USER_B_ID, coords3, "User B Copy"); repository.persist(original); repository.persist(userACopy); repository.persist(userBCopy); entityManager.flush(); // User A can reconcile original assertDoesNotThrow(() -> { managementService.reconcileWithProvider(USER_A_ID, original.getId(), "nominatim"); }); // User A can reconcile own copy assertDoesNotThrow(() -> { managementService.reconcileWithProvider(USER_A_ID, userACopy.getId(), "nominatim"); }); // User A CANNOT reconcile User B's copy assertThrows(ForbiddenException.class, () -> { managementService.reconcileWithProvider(USER_A_ID, userBCopy.getId(), "nominatim"); }); } @Test @Transactional @DisplayName("Reconciliation Test 8: Verify reconciliation preserves spatial data") void testReconciliationPreservesSpatialData() { // Given: Original entity Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Original Name"); repository.persist(original); entityManager.flush(); Long originalId = original.getId(); Point originalCoords = original.getRequestCoordinates(); // When: Reconcile assertDoesNotThrow(() -> { managementService.reconcileWithProvider(USER_A_ID, originalId, "nominatim"); }); // Then: Original coordinates should be preserved entityManager.clear(); ReverseGeocodingLocationEntity afterReconciliation = repository.findById(originalId); assertNotNull(afterReconciliation); assertEquals(originalCoords.getX(), afterReconciliation.getRequestCoordinates().getX(), 0.0001); assertEquals(originalCoords.getY(), afterReconciliation.getRequestCoordinates().getY(), 0.0001); } @Test @Transactional @DisplayName("Reconciliation Test 9: Verify reconciliation result is returned") void testReconciliationReturnsResult() { // Given: Original entity Point coords = coord(TEST_LON, TEST_LAT); ReverseGeocodingLocationEntity original = createOriginal(coords, "Test Location"); repository.persist(original); entityManager.flush(); // When: Reconcile ReverseGeocodingDTO result = managementService.reconcileWithProvider(USER_A_ID, original.getId(), "nominatim"); // Then: Result should be valid DTO assertNotNull(result); assertNotNull(result.getId()); assertNotNull(result.getDisplayName()); assertNotNull(result.getLongitude()); assertNotNull(result.getLatitude()); assertEquals(coords.getX(), result.getLongitude(), 0.01); assertEquals(coords.getY(), result.getLatitude(), 0.01); } private Point coord(double lon, double lat) { return coordinateScope.point(lon, lat); } }